fix(logger): defensively collect no git metadata when org returns nothing#453
Open
Alex R (alexr17) wants to merge 2 commits into
Open
fix(logger): defensively collect no git metadata when org returns nothing#453Alex R (alexr17) wants to merge 2 commits into
Alex R (alexr17) wants to merge 2 commits into
Conversation
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
is this a breaking change for self hosted customers? If it is, is that okay?
Alex R (alexr17)
force-pushed
the
fix/git-metadata-defensive-defaults
branch
from
119d970 to
2085913
Compare
Author
I'm not sure how breaking it would be but this is the direction we want to go in based on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the control plane returns no git_metadata configuration, the SDK now collects nothing instead of substituting SDK-side defaults. This eliminates duplicate default maintenance between SDK and control plane and aligns with feedback from the corresponding JS SDK PR.
Changes
DEFAULT_GIT_METADATA_FIELDSanddefault_git_metadata_settings()fromgit_fields.pylogger.py_check_org_info()to fall back tocollect="none"when org has no git_metadatagitutil.pyget_repo_info()to fall back tocollect="none"when settings is Noneframework.pyto reflect that collection defers to org-level settingsTest plan
test_corepass